Reviewing merge request #1: Handling the opening of image using handle.uri for tests

I have added the usage of handle.uri to open images in imageviewer that will be used for writing tests for imageviewer. The same approach was done for read and the commit for the same is in the given link and it has already been merged. link : https://git.sugarlabs.org/read/mainline/commit/77cc1020f4c7527b0066538028a12567e168fd07

Also did some pep8 fixes and removed a import line of the math library.

I am running flake8 for pep8 and pyflakes for the code, but it still shows a error :

ImageViewerActivity.py:193:31: E128 continuation line under-indented for visual indent

I was unable to fix to it.

Please review.

Thanks,
Gaurav

Requested by: Gaurav Parida
Status: Open
Source repository: gauravps-image:try1
Target repository: mainline:gtk3
Created at: August 3rd, 2014 17:01

Commits that would be merged:

Version 1

Version 1

367f354
ebd58fe

Handle a URI when the activity starts

Showing

Showing 367f354-ebd58fe

Comments
Include comments entered inline

Pushed new version 1

Gaurav Parida | 2014-08-03 17:02:01 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/1

# Fetch the merge request into this branch
git pull \
  git://git.sugarlabs.org/imageviewer/mainline.git \
  refs/merge-requests/1

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit gtk3..merge-requests/1

# To apply the changes to your branch:
git checkout gtk3
git merge merge-requests/1
git push origin gtk3

Reviewing merge request #1: Handling the opening of image using handle.uri for tests

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline